Skip to content

regalloc: removes map use for less memory pressure #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2024
Merged

regalloc: removes map use for less memory pressure #2211

merged 2 commits into from
May 21, 2024

Conversation

mathetake
Copy link
Member

This yields better perf on compilation as you see in the following bench result for
compiling the wazero CLI compiled as a Wasm binary:

$ benchstat old.txt new.txt
goos: darwin
goarch: arm64
pkg: github.com/tetratelabs/wazero
               │  old.txt   │           new.txt           │
               │   sec/op   │   sec/op    vs base         │
Compilation-10   3.467 ± 1%   3.523 ± 4%  ~ (p=0.073 n=7)

               │   old.txt    │              new.txt               │
               │     B/op     │     B/op      vs base              │
Compilation-10   396.2Mi ± 0%   392.7Mi ± 0%  -0.89% (p=0.001 n=7)

               │   old.txt   │              new.txt              │
               │  allocs/op  │  allocs/op   vs base              │
Compilation-10   718.9k ± 0%   693.2k ± 0%  -3.58% (p=0.001 n=7)

mathetake added 2 commits May 21, 2024 14:20
@mathetake
regalloc: removes map use for less memory pressure
ecc28fa 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
regalloc: simplifies the for loop over possible Real regs
9d77b6a 
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake mathetake marked this pull request as ready for review May 21, 2024 05:38
@mathetake mathetake merged commit ab0d27c into main May 21, 2024
64 checks passed
@mathetake mathetake deleted the regallocmap branch May 21, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mathetake